Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iFrameRate builtin to Shadertoy utility #453

Merged
merged 3 commits into from
Dec 18, 2023

Conversation

Vipitis
Copy link
Contributor

@Vipitis Vipitis commented Dec 18, 2023

While this doesn't show up in pygfx/shadertoy#15, I have seen this as an error at least once.
It should be simple to add, but understanding how the website implements it is a bit odd. The only reference I found is here: https://www.shadertoy.com/view/lsKGWV or the comment here: https://www.shadertoy.com/view/tlcfRB

So the implementation doesn't quite match the website but fits the literal definition. And it might be impossible to get a singular answer for this case, main idea being to avoid an "unknown variable" errors.

@Vipitis Vipitis requested a review from Korijn as a code owner December 18, 2023 21:12
@Korijn Korijn merged commit de21e25 into pygfx:main Dec 18, 2023
20 checks passed
@Vipitis Vipitis deleted the shadertoy-framerate branch December 18, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants