Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ruff instead of flake8 pyupgrade autoflake and isort #6

Merged
merged 1 commit into from
Oct 14, 2023

Conversation

Pierre-Sassoulas
Copy link
Member

Follow-up to #4 (can wait a new release compatible with pylint 3.0)

@Pierre-Sassoulas Pierre-Sassoulas added the enhancement New feature or request label Oct 14, 2023
@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (5ee69ce) 87.00% compared to head (ae436ac) 86.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
- Coverage   87.00%   86.96%   -0.04%     
==========================================
  Files          33       33              
  Lines         400      399       -1     
  Branches       81       81              
==========================================
- Hits          348      347       -1     
  Misses         48       48              
  Partials        4        4              
Files Coverage Δ
tests/test_cannot_enumerate_fixtures.py 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stdedos
Copy link
Collaborator

stdedos commented Oct 14, 2023

Follow-up to #4 (can wait a new release compatible with pylint 3.0)

No reason to make code stale, if pre-commit and tests agree.
I wanted to start with some scaffolding before doing the first "major" code MRs; these are fine.

Copy link
Collaborator

@stdedos stdedos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeeeah, hihihihi 🙃

check blanket noqa.......................................................Failed

  • hook id: python-check-blanket-noqa
  • exit code: 1

pylint_pytest/checkers/class_attr_loader.py:52: except Exception: # pylint: disable=broad-except # noqa
pylint_pytest/utils.py:118: except Exception: # pylint: disable=broad-except # noqa

You'd probably have to exclude the specific ruff error: https://docs.astral.sh/ruff/configuration/#error-suppression

@Pierre-Sassoulas
Copy link
Member Author

Ha my bad, the noqa was useless as I fixed it too.

@stdedos stdedos merged commit a1fc41e into master Oct 14, 2023
41 checks passed
@Pierre-Sassoulas Pierre-Sassoulas deleted the pre-commit-ruff branch October 14, 2023 13:05
@Pierre-Sassoulas
Copy link
Member Author

(Removed the lock on the master branch from the setting so it could be merged)

@stdedos
Copy link
Collaborator

stdedos commented Oct 15, 2023

Shouldn't it be there? I must be missing something from Github 😕

@Pierre-Sassoulas
Copy link
Member Author

Locking is locking, it means we can't merge anything. I think protection from push (you can only merge to master after a review) is what we need.

@stdedos stdedos added the CI label Oct 15, 2023
@stdedos stdedos added this to the Release 1.1.x milestone Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants