Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed splitting behaviour for PrePostFit #275

Merged
merged 2 commits into from
Dec 22, 2023

Conversation

rlaker
Copy link

@rlaker rlaker commented Nov 24, 2023

Fix for #273

@drbenvincent
Copy link
Collaborator

Thanks very much for this @rlaker! Just letting you know that this is on my list. Things are hectic but I will be able to request changes or approve/merge in the first few days of Dec. So around the end of this week.

@drbenvincent
Copy link
Collaborator

Sorry for the delay on this @rlaker. I think this is good to merge. We just have a failing test. Tests pass for me locally, so it could perhaps be a version issue, or sometimes remote tests randomly just fail. I'll try to trigger those tests again and see what happens.

@drbenvincent
Copy link
Collaborator

Remote failing tests should hopefully be fixed whenever pymc-devs/pytensor#550 is fixed and make its way into a new pytensor release. Or when #279 is resolved. So don't sink any effort into trying to fix failing remote tests right now. You can of course ensure that all local tests pass - they are not affected by the issue. Not on my machine anyway.

@drbenvincent drbenvincent added the bug Something isn't working label Dec 22, 2023
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c17fcf2) 75.86% compared to head (0c3f23d) 75.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #275   +/-   ##
=======================================
  Coverage   75.86%   75.86%           
=======================================
  Files          20       20           
  Lines        1305     1305           
=======================================
  Hits          990      990           
  Misses        315      315           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drbenvincent drbenvincent merged commit fc28a3b into pymc-labs:main Dec 22, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants