Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Different supports in component distributions for mixture models #1791

Merged
merged 7 commits into from
May 12, 2024
Merged

Different supports in component distributions for mixture models #1791

merged 7 commits into from
May 12, 2024

Conversation

Qazalbash
Copy link
Contributor

Fixes #1780.

fehiepsi
fehiepsi reviewed May 6, 2024
View reviewed changes
Copy link
Member

@fehiepsi fehiepsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @Qazalbash! Could you add a simple test to check whether a mixture of Normal and HalfNormal is computed correctly?

@Qazalbash Qazalbash requested a review from fehiepsi May 7, 2024 11:57
@Qazalbash
Copy link
Contributor Author

@fehiepsi I have made the changes and added the unit tests.

fehiepsi
fehiepsi reviewed May 7, 2024
View reviewed changes
numpyro/distributions/mixtures.py Outdated Show resolved Hide resolved
numpyro/distributions/mixtures.py Outdated Show resolved Hide resolved
numpyro/distributions/mixtures.py Outdated Show resolved Hide resolved
numpyro/distributions/mixtures.py Show resolved Hide resolved
test/test_distributions_mixture.py Outdated Show resolved Hide resolved
numpyro/distributions/mixtures.py Show resolved Hide resolved
test/test_distributions_mixture.py Outdated Show resolved Hide resolved
test/test_distributions_mixture.py Outdated Show resolved Hide resolved
@Qazalbash Qazalbash requested a review from fehiepsi May 9, 2024 07:27
fehiepsi
fehiepsi approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@fehiepsi fehiepsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature! Thanks @Qazalbash!

@Qazalbash
Copy link
Contributor Author

I used python3.11, let me test everything on python3.9!

@Qazalbash
Copy link
Contributor Author

Apparently, all these tests were passing on python3.11. They are still failing on different atol values.

@fehiepsi fehiepsi merged commit 1d0cedb into pyro-ppl:master May 12, 2024
4 checks passed
@Qazalbash Qazalbash deleted the mixturesupport branch May 13, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fehiepsi fehiepsi fehiepsi approved these changes

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR] Support for different supports in component distributions for mixture models
2 participants
@Qazalbash @fehiepsi