Make figure in AR2 example reproducible #1816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damonbayer
changed the title
|
CI checks should now pass. Sorry about that. |
fehiepsi
reviewed
Jun 18, 2024
examples/ar2.py
Outdated
| @@ -64,8 +64,6 @@ def transition(carry, _): | |||
| with numpyro.handlers.condition(data={"y": y[2:]}): | |||
| _, mu = scan(transition, init, timesteps) | |||
|
|
|||
| numpyro.deterministic("mu", mu) | |||
There was a problem hiding this comment.
Fixed in 8ebbaa7
|
@fehiepsi I don't think any of the test failures are related to my contribution. Please let me know if you disagree. |
|
Yes they are unrelated - @juanitorduz is working on them in #1817 |
|
@damonbayer Could you sync with master? They are fixed upstream. |
|
@fehiepsi Fork is synced! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds back in code to produce the ar2 plot in the ar2 example. This is based on the code that was removed in #1350. It was last available in https://github.com/pyro-ppl/numpyro/blob/c5b1a9229daf964a98eb12a8ad905e0d0a6c9437/examples/ar2.py.
The figure was generated with:
Closes #1815.