Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated numpy aliases #458

Merged
merged 4 commits into from
May 29, 2024
Merged

Conversation

eendebakpt
Copy link
Contributor

Description

Numpy 2.0 is to be released soon (see numpy/numpy#24300 (comment)) and that release will remove a couple of deprecated aliases.

In this PR replace the aliases by the entries suggested by ruff (see https://docs.astral.sh/ruff/rules/numpy2-deprecation/)

Checklist

  • Fixed style issues using pre-commit run --all (first install using pip install pre-commit)
  • pytest passed

Type of change

Check relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • (Code) style fix or documentation update
  • This change requires a documentation update

@eendebakpt
Copy link
Contributor Author

@akhmerov Tests are passing locally, not sure what is happening to the CI

@basnijholt
Copy link
Member

Thanks a lot! I think we first need to merge #404 to get the tests to pass. I'll do that in a few hours.

@basnijholt basnijholt merged commit 190b57b into python-adaptive:main May 29, 2024
13 of 15 checks passed
@jakirkham
Copy link

Thanks all! 🙏

Would it make sense to do a new release with these changes? Or are there other steps still needed before releasing?

@basnijholt
Copy link
Member

@jakirkham I just released 1.3.0 🎉

@jakirkham
Copy link

Congratulations and thank you again! 🥳 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants