Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement "sequential" strategy for BalancingLearner #460

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Implement "sequential" strategy for BalancingLearner #460

wants to merge 2 commits into from

Conversation

basnijholt
Copy link
Member

@basnijholt basnijholt commented Jun 3, 2024 •
edited
Loading

Description

Implement "sequential" strategy for BalancingLearner

Checklist

  • Fixed style issues using pre-commit run --all (first install using pip install pre-commit)
  • pytest passed

Type of change

Check relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • (Code) style fix or documentation update
  • This change requires a documentation update

@basnijholt basnijholt mentioned this pull request Jun 3, 2024
Open
akhmerov
akhmerov approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@akhmerov akhmerov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems alright to me. Out of curiousity, what's the use case?

akhmerov
akhmerov approved these changes Jun 3, 2024 •
edited
Loading
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akhmerov akhmerov akhmerov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@basnijholt @akhmerov