add nvidia driver for cuda arm wheel #5218
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tinglvv is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
facebook-github-bot
added
the
CLA Signed
nWEIdia
reviewed
May 19, 2024
| @@ -8,6 +8,10 @@ inputs: | |||
| required: false | |||
| type: string | |||
| default: "550.54.15" # https://docs.nvidia.com/datacenter/tesla/tesla-release-notes-550-54-15/index.html | |||
| GPU_ARCH_TYPE: | |||
| required: true | |||
| type: string | |||
There was a problem hiding this comment.
can we set a default "x86" and only add if statement for sbsa
nWEIdia
reviewed
May 19, 2024
| GPU_ARCH_TYPE: ${{ inputs.GPU_ARCH_TYPE }} | ||
| ${{ if eq(inputs.GPU_ARCH_TYPE , 'cuda-aarch64') }}: | ||
| ARCH_TYPE: sbsa | ||
| ${{ else }}: |
There was a problem hiding this comment.
this else would be x86_64 by default, so we can remove this if you set it to default.
nWEIdia
reviewed
May 19, 2024
nWEIdia
reviewed
May 20, 2024
| description: GPU Arch type #"cuda", "cuda-aarch64" | ||
| required: false | ||
| type: string | ||
| ARCH_TYPE: |
There was a problem hiding this comment.
How is ARCH_TYPE used?
I think it is safe to assume setup-nvidia is only called for GPU instances, where if it is not cuda, it must be cuda-aarch64.
GPU_ARCH_TYPE is enough?
tinglvv
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.