Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NKRO and Mouse Emulation on arm_atsam #23945

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Fix NKRO and Mouse Emulation on arm_atsam #23945

wants to merge 8 commits into from
+17 −1

Conversation

Izumemori
Copy link

@Izumemori Izumemori commented Jun 17, 2024 •
edited
Loading

Description

Removes report_id from the NKRO report struct for the arm_atsam protocol for NKRO and mouse emulation.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Jun 17, 2024
@Izumemori Izumemori changed the base branch from master to develop June 17, 2024 12:20
@drashna drashna requested a review from a team June 18, 2024 10:22
fauxpark
fauxpark requested changes Jun 21, 2024
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fixed in the ATSAM code, not report.h.

@Izumemori
Copy link
Author

This should be fixed in the ATSAM code, not report.h.

I've moved the same behavior to main_arm_atsam.c.

@Izumemori Izumemori requested a review from fauxpark June 21, 2024 19:56
@Izumemori Izumemori requested a review from drashna July 11, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark Awaiting requested review from fauxpark

@drashna drashna Awaiting requested review from drashna

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] NKRO distorts keymap on Drop CTRL board
3 participants
@Izumemori @drashna @fauxpark