Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SymbolicsUtils.expand function for QAdd #205

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

oameye
Copy link
Contributor

@oameye oameye commented May 5, 2024

add overload to expand as suggested in #204

@david-pl
Copy link
Member

david-pl commented May 7, 2024

@oameye thanks for opening a PR here! One small thing though: now that I look at the code, the dispatch should actually be x::QNumber. Otherwise that will throw a MethodError and it should just work if you change the function signature.

@david-pl david-pl merged commit 1cfc729 into qojulia:master Jul 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants