Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify documentation of Hibernate ORM dialects wrt database multi-tenancy #41761

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Clarify documentation of Hibernate ORM dialects wrt database multi-tenancy #41761

merged 3 commits into from
Jul 10, 2024

Conversation

yrodiere
Copy link
Member

@yrodiere yrodiere commented Jul 8, 2024

Fixes #41754

@quarkus-bot quarkus-bot bot added area/docstyle issues related for manual docstyle review area/documentation area/hibernate-orm Hibernate ORM area/persistence labels Jul 8, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 8, 2024

/cc @gsmet (hibernate-orm)

@quarkus-bot quarkus-bot bot added this to To do in Quarkus Documentation Jul 8, 2024
@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot

This comment has been minimized.

Sign in to view
marko-bekhta
marko-bekhta reviewed Jul 9, 2024
View reviewed changes
Copy link
Contributor

@marko-bekhta marko-bekhta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice 😃 👍🏻

I've added a couple of comments and the CI seems to complain about formatting 😖 😕

docs/src/main/asciidoc/hibernate-orm.adoc Outdated Show resolved Hide resolved
...-orm-tenancy/connection-resolver-legacy-qualifiers/src/main/resources/application.properties Show resolved Hide resolved
...ent/src/main/java/io/quarkus/hibernate/orm/deployment/HibernateOrmConfigPersistenceUnit.java Outdated Show resolved Hide resolved
docs/src/main/asciidoc/hibernate-orm.adoc Show resolved Hide resolved
docs/src/main/asciidoc/hibernate-orm.adoc Outdated Show resolved Hide resolved
@quarkus-bot quarkus-bot bot added the area/spring Issues relating to the Spring integration label Jul 9, 2024
@yrodiere
Copy link
Member Author

yrodiere commented Jul 9, 2024

Thanks @marko-bekhta , I addressed your comments!

marko-bekhta
marko-bekhta approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@marko-bekhta marko-bekhta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 😃 🎉

@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot

This comment has been minimized.

Sign in to view
@yrodiere
Clean up configuration examples in Hibernate ORM extension guide
e59993b 
1. Use callouts, not comments.
2. Use links to other guides.
3. Explain the "why" where necessary.
4. Fix weird mix of default and `base` datasource in database
   multitenancy example.
@yrodiere
Clarify documentation of Hibernate ORM dialects wrt database multi-te…
81ecc46 
…nancy
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 9, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 81ecc46.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

⚠️ There are other workflow runs running, you probably need to wait for their status before merging.

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 9, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 81ecc46.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

Quarkus Documentation automation moved this from To do to Reviewer approved Jul 9, 2024
@gastaldi gastaldi merged commit cc4ab0e into quarkusio:main Jul 10, 2024
44 checks passed
Quarkus Documentation automation moved this from Reviewer approved to Done Jul 10, 2024
@quarkus-bot quarkus-bot bot added this to the 3.13 - main milestone Jul 10, 2024
@github-actions GitHub Actions
Copy link

🙈 The PR is closed and the preview is expired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

@marko-bekhta marko-bekhta marko-bekhta approved these changes

Assignees
No one assigned
Labels
area/docstyle issues related for manual docstyle review area/documentation area/hibernate-orm Hibernate ORM area/persistence area/spring Issues relating to the Spring integration kind/bugfix
Projects
Quarkus Documentation
Done
Milestone
3.13.0.CR1
Development

Successfully merging this pull request may close these issues.

Hibernate ORM - Database multitenancy example from documentation does not work
3 participants
@yrodiere @gastaldi @marko-bekhta