Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid storing timestamp in Gradle.properties #41762

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

gastaldi
Copy link
Contributor

@gastaldi gastaldi commented Jul 8, 2024

@gastaldi gastaldi requested a review from maxandersen July 8, 2024 16:04
@quarkus-bot quarkus-bot bot added area/amazon-lambda area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/platform Issues related to definition and interaction with Quarkus Platform labels Jul 8, 2024
@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure labels Jul 8, 2024
@gsmet
Copy link
Member

gsmet commented Jul 8, 2024

Does it also avoid rewriting the file and respect the formatting of the existing file? Because I think that's what the original issue was about.

@gastaldi
Copy link
Contributor Author

gastaldi commented Jul 8, 2024

@gsmet yes, I tested locally and the order is preserved. In another words, running the steps from the original issue does not change the properties file

@quarkus-bot

This comment has been minimized.

Comment on lines +51 to +54
try (StringWriter sw = new StringWriter()) {
getModel().getRootPropertiesContent().store(sw, "Gradle properties");
Files.writeString(rootProjectPath.resolve(GRADLE_PROPERTIES_PATH),
sw.toString());
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using StringWriter because of codejive/java-properties#23

@quarkus-bot

This comment has been minimized.

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 9, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 423b4f4.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 independent-projects/resteasy-reactive/server/vertx

org.jboss.resteasy.reactive.server.vertx.test.sse.SseServerTestCase.shouldNotTryToSendToClosedSink - History

  • 1 expectation failed. Response body doesn't match expectation. Expected: "true" Actual: false - java.lang.AssertionError
java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.
Expected: "true"
  Actual: false

	at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)

⚙️ Native Tests - Messaging1

📦 integration-tests/reactive-messaging-kafka

io.quarkus.it.kafka.KafkaConnectorIT.testRequestReply - History

  • iterable contents differ at index [3], expected: <reply-4> but was: <{"details":"Error id 3816f35d-6178-4e7c-843d-27cbfb52fb46-1","stack":""}> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: iterable contents differ at index [3], expected: <reply-4> but was: <{"details":"Error id 3816f35d-6178-4e7c-843d-27cbfb52fb46-1","stack":""}>
	at io.quarkus.it.kafka.KafkaConnectorTest.testRequestReply(KafkaConnectorTest.java:111)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:812)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a nice improvement. I will merge.

Could you have a look at what @radcortez did in the quarkus config CLI? Maybe it would benefit from this too.

@gsmet gsmet merged commit e381882 into quarkusio:main Jul 9, 2024
53 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.13 - main milestone Jul 9, 2024
@gsmet gsmet modified the milestones: 3.13 - main, 3.12.2 Jul 9, 2024
@maxandersen
Copy link
Contributor

awesome stuff @gastaldi !

@gastaldi gastaldi deleted the gradle_props branch July 10, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/amazon-lambda area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/platform Issues related to definition and interaction with Quarkus Platform kind/bugfix triage/backport-3.8 triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running Quarkus CLI rewrites gradle.properties
3 participants