Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign simulator switching system #283

Merged
merged 16 commits into from
Jun 18, 2023
Merged

Redesign simulator switching system #283

merged 16 commits into from
Jun 18, 2023

Conversation

zergud
Copy link
Collaborator

@zergud zergud commented Jun 15, 2023

fixes #274

@ra3xdh ra3xdh added this to the 1.1.1 milestone Jun 15, 2023
@ra3xdh
Copy link
Owner

ra3xdh commented Jun 16, 2023

I have tested this PR and found the following problems:

  • New system cannot recognize simulator if it is defined using $PATH. This case is common for Linux platform. For example it cannot find qucsator on my Linux system.
    image

I suggest to implement a custom search procedure instead of using simple QFile::exists(). It should look for executable also in $PATH.

  • An addition to the previous point. I have implemented an automatic search of the Ngspice exexcutable in order to prepare application for the build of Windows installer. This feature may be combined to simulator selection. See 7a77ceb

  • It is possible to set simulator to Not specified and simulation doesn't work in such case. Only simulators should be available in the drop-down list.
    image

  • On the first start the applications reads old settings from config file and sets simulator to Not specified. As the solution I may suggest to rename the setting in the config (see saveSettings() and loadSettings in main.cpp). Also it may help to shift bit mask of the spicecompat::Simulator The range from 0x00 to 0x0F will indicate old settings before v1.1.1 and it's need to show the settings dialog on the first start again.

  • The blue BJT, MOSFET, and JFET symbols should be available for all simulators, but not only for Qucsator.

@ra3xdh
Copy link
Owner

ra3xdh commented Jun 17, 2023

Now everything seems to work as expected except the problem with simulators in $PATH I will try to provide the solution for this problem in the next few days.

@ra3xdh
Copy link
Owner

ra3xdh commented Jun 17, 2023

See https://github.com/zergud/qucs_s/pull/2 for solution of the $PATH search problem.

@ra3xdh ra3xdh merged commit eca85bb into ra3xdh:current Jun 18, 2023
1 check passed
@ra3xdh
Copy link
Owner

ra3xdh commented Jun 18, 2023

I have tested it again and found no remaining problems. Merging this. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redesign of simulator switching system
2 participants