Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getter and Setter of playlist api endpoint #439

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

tomkimsour
Copy link

Description

Please include a summary of the change and which issue is fixed
Getter and setter for playlist cover are missing as mentioned here #377 and #438

Motivation and Context

Please also include relevant motivation and context.

Dependencies

None

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How has this been tested?

I am yet trying to test both function under test_with_oauth.rs by creating a playlist, adding a cover, retrieving it and comparing both.
However I need guidance on how to test it as I am not able to figure out how to oauth for the tests. I am not sure what are the variable values required in the .env and even if I put a wrong value, it doesn't seem like the value is being read.

Is this change properly documented?

yes

@tomkimsour tomkimsour changed the title Add image cover Getter and Setter of playlist api endpoint Aug 30, 2023
@ramsayleung
Copy link
Owner

You could take the current_playing endpoint for example, test your new endpoint by

  1. Add an example file
  2. Add an entry in cargo.toml
  3. Run your example with cargo: cargo run --example your-new-example --features env-file,cli,client-reqwest, the cli will prompt you to authenticate and get the auth code.

@tomkimsour
Copy link
Author

So no unit testing ? just an example instead ?

@ramsayleung
Copy link
Owner

The example acts like an end-to-end test for the new endpoint, because as we discussed in this issue: #154 (comment), there is no workable approach for us to run unit test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants