Make client and server to resync active connections #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aruiz14
commented
Apr 5, 2024
aruiz14
commented
Apr 5, 2024
moio
reviewed
Apr 5, 2024
aruiz14
commented
Apr 9, 2024
rmweir
suggested changes
Apr 22, 2024
tomleb
reviewed
Apr 24, 2024
There was a problem hiding this comment.
This seems to follow what we discussed during our meeting.
Given the potential deadlock mentioned in the comments below, I think this requires more testing. It should be tested in a custom Rancher build and it would be beneficial imo to have integration tests for this, though I understand that right now remotedialer doesn't have this in place.
aruiz14
force-pushed
the
resync-protocol
branch
from
e8d07f6
to
1bdf8ed
Compare
1 task
moio
previously approved these changes
Jun 13, 2024
aruiz14
added a commit
to aruiz14/remotedialer
that referenced
this pull request
Jun 13, 2024
aruiz14
added a commit
to rancher/rancher
that referenced
this pull request
Jun 13, 2024
aruiz14
added a commit
to rancher/rancher
that referenced
this pull request
Jun 14, 2024
maxsokolovsky
requested changes
Jun 14, 2024
moio
approved these changes
Jun 24, 2024
|
@maxsokolovsky do we have your final blessing to merge this, so that it has a chance to get into future 2.9.0 alphas? |
aruiz14
added a commit
to rancher/rancher
that referenced
this pull request
Jun 26, 2024
maxsokolovsky
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: 44576
Relates to #68
Depends on #78
Problem
remotedialer allows multiplexing connections between two peers using a single websocket connections by including a connection ID in the messages and using separate buffers. The protocol specifies different message types for different actions (
Connect,Data,Error,Pause,Resume, etc.). In particular, theErrortype is used to communicate the other end that a certain connection must be closed. However, depending on the cause of the original error, this message may never be successfully transmitted, as the sender will give up on sending it (#67 adds additional logging for this situation).When this happens, one of the peers will never receive a termination message for that connection, making the underlying buffers to get stuck on
Read()forever, hence causing goroutine and memory leaks.Solution
This PR adds a new message type to the protocol (
Resync), whose payload contains a list of connection IDs. Similarly to how clients sendsPingcontrol messages,Resyncmessages will periodically tell the receiving peer that any connection not contained in the provided list is no longer needed and can be pruned.Small caveat: we cannot use Control messages for this purpose, since websocket set a limit of 125 bytes for their payload, which would impose a tight restriction on the number of connections.
CheckList