Fix deprecation warnings #5044
Open
Fix deprecation warnings #5044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwmac
force-pushed
the
fix-deprecation-warnings
branch
from
0a4b433
to
ac92604
Compare
nwmac
force-pushed
the
fix-deprecation-warnings
branch
from
ac92604
to
2ee9eaf
Compare
mantis-toboggan-md
requested changes
Dec 1, 2023
| @@ -125,7 +125,7 @@ export default Resource.extend({ | |||
|
|
|||
| this.registerDynamicComputedProperty('displaySize', computedKeys, size.getDisplayProperty); | |||
| } else { | |||
| set(this, 'displaySize', get(this, 'config.size') || 'N/A'); | |||
| // set(this, 'displaySize', get(this, 'config.size') || 'N/A'); | |||
There was a problem hiding this comment.
Was this included intentionally? Seems unrelated
There was a problem hiding this comment.
This component is still referenced in another component. Pipelines have been deprecated since 2.5, can we remove all pipeline code now?? Probably deserves its own PR though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of working to update to Ember 3.28, this PR updates lint rule so string prototype extensions fail the lint.
Addresses string prototype extension uses and uses
@ember\stringfunctions.This addresses a first set of deprecation warnings that you would see in the browser console.