Removing monitoring #5139
Merged
Removing monitoring #5139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-cox
reviewed
Apr 23, 2024
No, you're right. I was too focused on the backport issue and missed it rancher/dashboard#10276. I'll update and request again. |
Logging had already been removed from the navigation menu but the translation was still present. I removed the translation for completeness. I left the routes and pages just in case we need to allow the customer to visit those pages even if it's unlikely. We will eventually fully remove ember so I don't think there's a reason to tidy up too much in this scenario. rancher/dashboard#10617
codyrancher
force-pushed
the
monitoring-removal
branch
from
d81fd05
to
da78991
Compare
richard-cox
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Removing monitoring and logging navigation
Types of changes
Deprecation
Linked Issues
rancher/dashboard#10617
Further comments
Logging had already been removed from the navigation menu but the translation was still present. I removed the translation for completeness.
I left the routes and pages just in case we need to allow the customer to visit those pages even if it's unlikely. We will eventually fully remove ember so I don't think there's a reason to tidy up too much in this scenario.
Cluster monitoring page:
Projects Page:
