-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PQC: ML-KEM (Initial Public Draft) #3893
base: master
Are you sure you want to change the base?
Conversation
20da875
to
8c19232
Compare
@reneme, that's great news. I highly appreciate that the different versions can be controlled in the build and invoked at run-time independently.
|
8c19232
to
2dcd938
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This adds ML-KEM-ipd as new modes in the Kyber implementation. It also integrates the new algorithm into the library's higher level APIs under the name "ML-KEM-ipd". Currently, neither TLS nor the FFI layer support it.
2dcd938
to
f3481b2
Compare
With #4024 merged, this is now directly based on master and (finally) ready for prime time. The code to actually make ML-KEM-ipd happen isn't a lot, apart from the various Right now the module is marked as 'experimental' and won't be built unless
|
Descriptions
This builds on the existing Kyber implementation (and the flexibility added in #3387 and #4024) to provide an implementation of ML-KEM as specified in the "initial public draft". Test vectors are taken from the reference implementation.
Note that each flavor of Kyber/ML-KEM can be disabled at compile time via the modules
kyber
,kyber_90s
,ml_kem_ipd
.Caveats
It is somewhat unclear what the support guarantees should be for this. Perhaps we shouldn't even merge it into
master
but leave the Pull Request open until NIST publishes the final standard and never even release support for ML-KEM-ipd. At the moment theml_kem_ipd
module is marked experimental for that reason.Note that it is an addition! Kyber-R3 (and 90s mode) continue to work as before.
Currently, I didn't expose ML-KEM-ipd in the FFI (or the python wrapper) and also didn't make it available in hybrid-TLS.
Example