chore(ci): check GitHub Action workflow files via actionlint #1175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orhun
requested review from
joshka,
kdheepak,
Valentin271 and
EdJoPaTo
as code owners
joshka
approved these changes
Jun 10, 2024
EdJoPaTo
reviewed
Jun 11, 2024
| @@ -46,6 +46,10 @@ jobs: | |||
| uses: crate-ci/typos@master | |||
| - name: Lint dependencies | |||
| uses: EmbarkStudios/cargo-deny-action@v1 | |||
| - name: Check workflow files | |||
| uses: docker://rhysd/actionlint:latest | |||
There was a problem hiding this comment.
Not sure its really useful to keep this always running. CI is changing not that often. A link to the online check tool might be more relevant.
There was a problem hiding this comment.
I think it's fine, it's not much of a resource heavy thing anyways.
There was a problem hiding this comment.
Perhaps gate it on the path - not sure I like the docker approach to running something like this as this becomes a barrier to security auditing.
There was a problem hiding this comment.
There are other ways of using this as well: https://github.com/rhysd/actionlint/blob/main/docs/usage.md
The docker approach looked safer than yolo-downloading a script and running it so I went with that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/rhysd/actionlint