Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(chart): add GraphType::Bar #1205

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(chart): add GraphType::Bar #1205

wants to merge 1 commit into from

Conversation

joshka
Copy link
Member

@joshka joshka commented Jun 27, 2024

Demo

@codecov Codecov
Copy link

codecov bot commented Jun 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.4%. Comparing base (3e7458f) to head (f6a5bcf).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@          Coverage Diff          @@
##            main   #1205   +/-   ##
=====================================
  Coverage   94.4%   94.4%           
=====================================
  Files         62      62           
  Lines      15048   15092   +44     
=====================================
+ Hits       14217   14261   +44     
  Misses       831     831

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshka
Copy link
Member Author

joshka commented Jun 27, 2024

Inspired by btop, it might be nice to be able to have graphs that can be bar charts and not just lines / scatter.
image

@joshka joshka added the Status: Review Needed PR needs a review / Issue needs buy-in from other maintainers / users label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orhun orhun Awaiting requested review from orhun orhun is a code owner

@kdheepak kdheepak Awaiting requested review from kdheepak kdheepak is a code owner

@Valentin271 Valentin271 Awaiting requested review from Valentin271 Valentin271 is a code owner

@EdJoPaTo EdJoPaTo Awaiting requested review from EdJoPaTo EdJoPaTo is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Status: Review Needed PR needs a review / Issue needs buy-in from other maintainers / users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@joshka