Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core]create internal module for thridparty system compatible building #44066

Merged
merged 8 commits into from
Mar 28, 2024

Conversation

ashione
Copy link
Member

@ashione ashione commented Mar 16, 2024

Exporting internal module

Related issue number

Closes #44065

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

src/ray/internal/internal.h Outdated Show resolved Hide resolved
@larrylian
Copy link
Contributor

@jjyao
internal.cc/internal.h and exported_internal has been removed in this PR #34697 (Because it was thought to be unused. However, in reality, Mobius is using it.)

Now it block build the mobius project update ray version (old version -> ray lastest 2.9.3) ray-project/mobius#60 .
I think we should merge this revert PR first, to support the Mobius upgrade of the Ray version.

@ashione
Copy link
Member Author

ashione commented Mar 24, 2024

@robertnishihara @raulchen @SongGuyang Anyone can take over ray core module management? Seems no one can go on developing.

@ashione ashione requested a review from jjyao March 24, 2024 13:29
@SongGuyang
Copy link
Contributor

Seems that the exported internal flags were deleted accidentally. I will merge this PR if there are no more other comments.

Copy link
Collaborator

@jjyao jjyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add these code to mobius repo?

We should add some comment saying that the code is used by an external repo otherwise it's guaranteed to be removed in the future by someone without context.

@ashione
Copy link
Member Author

ashione commented Mar 26, 2024

Can we add these code to mobius repo?

We should add some comment saying that the code is used by an external repo otherwise it's guaranteed to be removed in the future by someone without context.

Thirdparty can not decide what symbols ray should be exported? Usually opensource system made it in main repo.

#include "ray/common/id.h"
#include "ray/core_worker/common.h"
#include "ray/stats/metric.h"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add comments to the code saying where it's used so people don't accidentally delete it again in the future?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add comments to the code saying where it's used so people don't accidentally delete it again in the future?

Comments had been added in internal header file.

@jjyao jjyao merged commit 5e7b3c3 into master Mar 28, 2024
4 of 5 checks passed
@jjyao jjyao deleted the revert-internal-module-removed branch March 28, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Important Module Removed] internal.cc/internal.h had been remove, but it's related to mobius.
5 participants