Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation for "You Might Not Need an Effect" #854

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

boldurean
Copy link

@boldurean boldurean commented Apr 27, 2023

This PR translates "You Might Not Need an Effect"

I also "partially" translated some of the layout components such as "DeepDive", "Note", "Recap" and etc.

Next list of browsers was used for testing:

  • Safari: version 16.4 (18615.1.26.11.23) including iOS 16.4
  • Chrome: version 112.0.5615.137 (arm64)
  • Edge: version 112.0.1722.58 (arm64)
  • FireFox: version 112.0.2 (arm64)

Some of the screenshots:

Screenshot 2023-04-27 at 20 28 23

Screenshot 2023-04-27 at 20 35 42

Screenshot 2023-04-27 at 20 35 28

Screenshot 2023-04-27 at 20 35 02

Screenshot 2023-04-27 at 20 34 29

Screenshot 2023-04-27 at 20 33 14

Screenshot 2023-04-27 at 20 31 52

Screenshot 2023-04-27 at 20 31 16

Screenshot 2023-04-27 at 20 28 35

@ntishkevich
Copy link
Collaborator

Спасибо за перевод. Если Tailwind-prettier ваш плагин, то просьба его отключить и вернуть измененный порядок css классов в исходный по той причине, что последующие обновления документации будут вызывать на этих строчках конфликты и придется разбираться обновлялись ли стили в английской документации при разрешении конфликтов.

@boldurean
Copy link
Author

boldurean commented Apr 27, 2023

Спасибо за перевод. Если Tailwind-prettier ваш плагин, то просьба его отключить и вернуть измененный порядок css классов в исходный по той причине, что последующие обновления документации будут вызывать на этих строчках конфликты и придется разбираться обновлялись ли стили в английской документации при разрешении конфликтов.

Прошу прощения, проглядел. Плагин мой, совсем не подумал о будущих конфликтах. Сделал откат оставив только перевод + убрал упоминание в PR.

Copy link
Contributor

@fpetrakov fpetrakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Привет, спасибо за перевод, чуть посмотрел, есть предложения, что думаешь?

src/content/learn/you-might-not-need-an-effect.md Outdated Show resolved Hide resolved
src/content/learn/you-might-not-need-an-effect.md Outdated Show resolved Hide resolved
src/content/learn/you-might-not-need-an-effect.md Outdated Show resolved Hide resolved
src/content/learn/you-might-not-need-an-effect.md Outdated Show resolved Hide resolved
src/content/learn/you-might-not-need-an-effect.md Outdated Show resolved Hide resolved
src/content/learn/you-might-not-need-an-effect.md Outdated Show resolved Hide resolved
src/content/learn/you-might-not-need-an-effect.md Outdated Show resolved Hide resolved
boldurean and others added 3 commits April 29, 2023 18:20
Да, я немного не понял семантического смысла, действительно менять, изменять было будет правильней.

Co-authored-by: Fedya Petrakov <[email protected]>
@boldurean
Copy link
Author

@fpetrakov, спасибо за корректировки. При переводе таких длинных страниц очень сильно замыливается перевод)

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 103.15 KB (-1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 75.73 KB (🟡 +337 B) 178.88 KB
/500 75.72 KB (🟡 +337 B) 178.88 KB
/[[...markdownPath]] 77.18 KB (🟡 +337 B) 180.33 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@boldurean
Copy link
Author

ПР висит уже пару месяцев, есть какие-то дополнения?)

@boldurean
Copy link
Author

Конфликты пофикшены, но если какие-то другие ветки вольют, то снова появятся)

@boldurean
Copy link
Author

Ребят, что-то вообще в репе тихо...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants