Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LightFM from core package #2122

Merged
merged 4 commits into from
Jul 1, 2024
Merged

Conversation

miguelgfierro
Copy link
Collaborator

Description

It seems LightFM is not supported anymore. It is currently blocking the support of Python 3.12 #2097. @daviddavo even fixed the problem in their repo lyst/lightfm#710 but there is no response from the maintainers.

Related Issues

#2115

References

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • I have signed the commits, e.g. git commit -s -m "your commit message".
  • This PR is being made to staging branch AND NOT TO main branch.

Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: miguelgfierro <[email protected]>
@miguelgfierro miguelgfierro changed the title Remove LightFM of core package Remove LightFM from core package Jun 29, 2024
@miguelgfierro
Copy link
Collaborator Author

==================================== ERRORS ====================================
_ ERROR collecting tests/data_validation/recommenders/datasets/test_movielens.py _
tests/data_validation/recommenders/datasets/test_movielens.py:23: in <module>
    from recommenders.datasets.movielens import MockMovielensSchema
recommenders/datasets/movielens.py:585: in <module>
    class MockMovielensSchema(pa.SchemaModel):
E   AttributeError: module 'pandera' has no attribute 'SchemaModel'
______ ERROR collecting tests/unit/recommenders/tuning/test_ncf_utils.py _______
tests/unit/recommenders/tuning/test_ncf_utils.py:9: in <module>
    from recommenders.datasets.movielens import MockMovielensSchema
recommenders/datasets/movielens.py:580: in <module>
    @extensions.register_check_method(statistics=["columns"], supported_types=pd.DataFrame)
/azureml-envs/azureml_36d38bfe693878b2e954f559f4339221/lib/python3.11/site-packages/pandera/api/extensions.py:309: in register_check_method
    return register_check_wrapper(check_fn)
/azureml-envs/azureml_36d38bfe693878b2e954f559f4339221/lib/python3.11/site-packages/pandera/api/extensions.py:244: in register_check_wrapper
    raise ValueError(
E   ValueError: method with name 'unique_columns' already defined. Check methods must have a unique method name.

@miguelgfierro miguelgfierro merged commit 41349b1 into staging Jul 1, 2024
38 checks passed
@miguelgfierro miguelgfierro deleted the miguel/lightfm_extras branch July 1, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants