Refactor output format framework to support tables and empty format #1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gowriswarupk
changed the title
wtrocki
reviewed
May 3, 2022
| go install github.com/redhat-developer/app-services-go-linter/cmd/app-services-go-linter@latest | ||
| endif | ||
| app-services-go-linter -path ./pkg/core/localize/locales ./... | ||
| .PHONY: lint-lang |
There was a problem hiding this comment.
This should not be there./
wtrocki
reviewed
May 3, 2022
| @@ -4,21 +4,26 @@ go 1.16 | |||
|
|
|||
| require ( | |||
| github.com/AlecAivazis/survey/v2 v2.3.4 | |||
| github.com/BurntSushi/toml v1.0.0 | |||
| github.com/BurntSushi/toml v1.1.0 | |||
There was a problem hiding this comment.
WE should not update those
|
Needs addressing comments from here: |
|
@rkpattnaik780 WDYT about this PR. I think we could drive that to main branch with some minimal work. |
That will be great. Few changes need to be made and should be properly tested before merging. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motiviation
Addressing issue #1429
Changes made:
Verification Steps:
-
./rhoas kafka topic create --name test --output none-
./rhoas kafka topic list --output table