Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(web): new field components #1017

Merged
merged 39 commits into from
Jul 12, 2024
Merged

refactor(web): new field components #1017

merged 39 commits into from
Jul 12, 2024

Conversation

m-abe-dev
Copy link
Contributor

@m-abe-dev m-abe-dev commented Jun 12, 2024

Overview

yarn storybook
http://localhost:9001/?path=/docs/beta-ui-fields--docs

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

Copy link

netlify bot commented Jun 12, 2024

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit dc796c1
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/6690e56ce9e6c200086bd55f
😎 Deploy Preview https://deploy-preview-1017--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@m-abe-dev m-abe-dev changed the title WIP chore(web): fields chore(web): create fields Jun 17, 2024
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 515 lines in your changes missing coverage. Please review.

Project coverage is 19.65%. Comparing base (2e67309) to head (5fee81a).
Report is 54 commits behind head on main.

Current head 5fee81a differs from pull request most recent head e45d877

Please upload reports for the commit e45d877 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1017      +/-   ##
==========================================
- Coverage   22.87%   19.65%   -3.23%     
==========================================
  Files        1570     1227     -343     
  Lines      167255   135069   -32186     
  Branches     2837     2881      +44     
==========================================
- Hits        38255    26544   -11711     
+ Misses     127846   108525   -19321     
+ Partials     1154        0    -1154     
Flag Coverage Δ
server ?
web 19.65% <0.00%> (-0.59%) ⬇️
web-beta 19.65% <0.00%> (-0.59%) ⬇️
web-classic 19.65% <0.00%> (-0.59%) ⬇️
web-utils 19.65% <0.00%> (-0.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
web/src/beta/ui/fields/index.ts 0.00% <0.00%> (ø)
web/src/beta/ui/fields/CodeField.tsx 0.00% <0.00%> (ø)
web/src/beta/ui/fields/SelectField.tsx 0.00% <0.00%> (ø)
web/src/beta/ui/fields/TimePointField.tsx 0.00% <0.00%> (ø)
web/src/beta/ui/fields/CameraField.tsx 0.00% <0.00%> (ø)
web/src/beta/ui/fields/TextareaField.tsx 0.00% <0.00%> (ø)
web/src/beta/ui/fields/AssetField.tsx 0.00% <0.00%> (ø)
web/src/beta/ui/fields/TwinInputField.tsx 0.00% <0.00%> (ø)
web/src/beta/ui/fields/TripletInputField.tsx 0.00% <0.00%> (ø)
web/src/beta/ui/fields/QuartetInputField.tsx 0.00% <0.00%> (ø)
... and 1 more

... and 644 files with indirect coverage changes

@m-abe-dev m-abe-dev force-pushed the chore/fields branch 2 times, most recently from 063642d to 79e5522 Compare July 1, 2024 12:28
web/src/beta/ui/fields/CameraField.tsx Outdated Show resolved Hide resolved
web/src/beta/ui/fields/CameraField.tsx Outdated Show resolved Hide resolved
web/src/beta/ui/fields/CameraField.tsx Outdated Show resolved Hide resolved
web/src/beta/ui/fields/CameraField.tsx Outdated Show resolved Hide resolved
web/src/beta/ui/fields/CameraField.tsx Outdated Show resolved Hide resolved
web/src/beta/ui/fields/TripletInputField.tsx Outdated Show resolved Hide resolved
web/src/beta/ui/fields/TwinInputField.tsx Outdated Show resolved Hide resolved
web/src/beta/ui/fields/TwinInputField.tsx Outdated Show resolved Hide resolved
web/src/beta/ui/fields/index.stories.tsx Outdated Show resolved Hide resolved
web/src/beta/ui/fields/index.stories.tsx Show resolved Hide resolved
server/yarn.lock Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the server label Jul 12, 2024
@airslice airslice changed the title chore(web): create fields refactor(web): new field components Jul 12, 2024
@mkumbobeaty mkumbobeaty enabled auto-merge (squash) July 12, 2024 08:24
@mkumbobeaty mkumbobeaty merged commit 6c6734b into main Jul 12, 2024
12 checks passed
@mkumbobeaty mkumbobeaty deleted the chore/fields branch July 12, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants