Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [WIP] refactor setCurrent to setPage #6088

Conversation

alicanerdurmaz
Copy link
Member

@alicanerdurmaz alicanerdurmaz commented Jun 28, 2024

🚨 Work in progress...

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

What is the current behavior?

What is the new behavior?

fixes #6087

Notes for reviewers

@alicanerdurmaz alicanerdurmaz requested a review from a team as a code owner June 28, 2024 14:06
Copy link

changeset-bot bot commented Jun 28, 2024

⚠️ No Changeset found

Latest commit: 46d1491

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alicanerdurmaz alicanerdurmaz marked this pull request as draft June 28, 2024 14:06
@alicanerdurmaz alicanerdurmaz added this to the July Release milestone Jun 28, 2024
Copy link

cypress bot commented Jun 28, 2024

30 failed tests on run #11253 ↗︎

30 351 37 0 Flakiness 0

Details:

Merge 46d1491 into 4265ae2...
Project: refine Commit: 10f77cc916 ℹ️
Status: Failed Duration: 33:57 💡
Started: Jun 28, 2024 2:17 PM Ended: Jun 28, 2024 2:51 PM
Failed  cypress/e2e/all.cy.ts • 1 failed test • inferencer-material-ui

View Output

Test Artifacts
inferencer-material-ui > should work with pagination Test Replay Screenshots
Failed  cypress/e2e/all.cy.ts • 3 failed tests • table-chakra-ui-basic

View Output

Test Artifacts
table-chakra-ui-basic > should work with sorter Test Replay Screenshots
table-chakra-ui-basic > should work with pagination Test Replay Screenshots
table-chakra-ui-basic > should set current `1` when filter changed Test Replay Screenshots
Failed  cypress/e2e/all.cy.ts • 4 failed tests • data-provider-strapi-v4

View Output

Test Artifacts
data-provider-strapi-v4 > useList > should list with pagination Test Replay Screenshots
data-provider-strapi-v4 > useList > should sort Test Replay Screenshots
data-provider-strapi-v4 > useList > should filter Test Replay Screenshots
data-provider-strapi-v4 > change locale > should change locale Test Replay Screenshots
Failed  cypress/e2e/all.cy.ts • 4 failed tests • data-provider-supabase

View Output

Test Artifacts
data-provider-supabase > useList > should list with pagination Test Replay Screenshots
data-provider-supabase > useList > should sort Test Replay Screenshots
data-provider-supabase > useList > should filter Test Replay Screenshots
data-provider-supabase > useShow > should show Test Replay Screenshots
Failed  cypress/e2e/all.cy.ts • 1 failed test • table-antd-table-filter

View Output

Test Artifacts
table-antd-table-filter > the table should be filterable by form Test Replay Screenshots

The first 5 failed specs are shown, see all 17 specs in Cypress Cloud.

Review all test suite changes for PR #6088 ↗︎

@alicanerdurmaz
Copy link
Member Author

After discussing this with the core team, we decided to implement it with Refine@5 because the syncWithLocation feature will cause a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] useTable's state names current and setCurrent are confusing.
1 participant