Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "feat: URI is not replacing the spec but merging instead (#1537) #1539

Merged
merged 1 commit into from
May 1, 2024
Merged

Revert "feat: URI is not replacing the spec but merging instead (#1537) #1539

merged 1 commit into from
May 1, 2024

Conversation

banjoh
Copy link
Member

@banjoh banjoh commented May 1, 2024 •
edited
Loading

Description, Motivation and Context

Revert cause of #1540 regression which has been released in https://github.com/replicatedhq/troubleshoot/releases/tag/v0.91.0

Checklist

  • New and existing tests pass locally with introduced changes.
  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) are informative and highlight any breaking changes
  • Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

  • Yes
  • No

@banjoh banjoh requested a review from a team as a code owner May 1, 2024 12:55
@banjoh banjoh changed the title Revert "feat: [sc-103119] URI is not replacing the spec but merging i… Revert "feat: URI is not replacing the spec but merging instead (#1537) May 1, 2024
@banjoh banjoh added type::chore type::bug Something isn't working bug::regression and removed type::chore labels May 1, 2024
@banjoh banjoh merged commit aeaac7a into replicatedhq:main May 1, 2024
27 checks passed
@banjoh banjoh deleted the em/revert-uri-field-change branch May 1, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danj-replicated danj-replicated danj-replicated approved these changes

Assignees
No one assigned
Labels
bug::regression type::bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@banjoh @danj-replicated