Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gerard/sc 106216/b registry image collector #1570

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Gerard/sc 106216/b registry image collector #1570

merged 2 commits into from
Jul 2, 2024

Conversation

nvanthao
Copy link
Member

@nvanthao nvanthao commented Jul 2, 2024

Description, Motivation and Context

Fixes: #1555

  • New and existing tests pass locally with introduced changes.
  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) are informative and highlight any breaking changes
  • Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

  • Yes
  • No

@nvanthao nvanthao requested a review from a team as a code owner July 2, 2024 03:30
@nvanthao nvanthao linked an issue Jul 2, 2024 that may be closed by this pull request
Image pull secrets containing colons causing registryImages collector to fail #1555
Closed
@xavpaice xavpaice added the type::bug Something isn't working label Jul 2, 2024
@nvanthao nvanthao requested a review from banjoh July 2, 2024 04:38
banjoh
banjoh approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@banjoh banjoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nvanthao nvanthao merged commit e882f44 into main Jul 2, 2024
27 checks passed
@nvanthao nvanthao deleted the gerard/sc-106216/b-registry-image-collector branch July 2, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banjoh banjoh banjoh approved these changes

Assignees
No one assigned
Labels
bug::normal type::bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Image pull secrets containing colons causing registryImages collector to fail
3 participants
@nvanthao @banjoh @xavpaice