Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: coding conventions #152

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Conversation

NathanFlurry
Copy link
Member

No description provided.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @NathanFlurry and the rest of your teammates on Graphite Graphite

Copy link
Collaborator

@Blckbrry-Pi Blckbrry-Pi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall, might make sense to consider adjacently tagged enums for exhaustive switch statements.

docs/CONVENTIONS.md Outdated Show resolved Hide resolved
docs/CONVENTIONS.md Outdated Show resolved Hide resolved
docs/CONVENTIONS.md Show resolved Hide resolved
docs/CONVENTIONS.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@Blckbrry-Pi Blckbrry-Pi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Maybe we can figure out something to make the sum types more robust later, but this is more than good enough for now.

@NathanFlurry NathanFlurry merged commit 32f0437 into main Mar 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants