Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Scheduler not compatible with BaseDupeFilter #294

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

HairlessVillager
Copy link

Description

Fixes #293

API change: add dupefilter=None argument in Scheduler.__init__().

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [] pytest
  • [] Other test (please specify)

Test Configuration:

  • OS version:
  • Necessary Libraries (optional):

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scrapy_redis.scheduler.Scheduler not compatible with scrapy.dupefilters.BaseDupeFilter
2 participants