Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix jwt in native app for qewd up. #39

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

faisalsami
Copy link

Fix where qewd up would not allow jwt support even if we add jwt in config.json file in case of native app .

Fix where qewd up would not allow jwt support even if we add jwt in config.json.
@geoidesic
Copy link

@faisalsami looks broken?

@robtweed
Copy link
Owner

I'm not going to make the suggested changes for two reasons: 1) I'm concerned that the CORS-related changes to Express headers and socket-io configuration could/may have negative consequences for other users; and 2) the versions of some of the modules you've made changes to are out of date compared with the QEWD Master version. I think the way to handle 1) would be to provide additional configuration settings via the config.json file and then conditionalise the code you suggest to use those specific configuration changes

@faisalsami
Copy link
Author

faisalsami commented Oct 26, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants