Fix Dcent hardware wallet personalSign #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
D'Cent wallet expects the string coming in to be a hex value and it was assumed the value was a pure string. In the research with Ethers.js and Web3.js those libraries were converting it to hex before sending it to the provider so the previous implementation would "double hex it". This was incorrect.
This fix checks if the value is a hex value and if not converts it.
Tested with provider.request, Ethers.js, and Web3.js using the Basic Sample Dapp locally.
This will resolve #60 and resolve rsksmart/rLogin#284