Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: database crash issue #449

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

1abhishekpandey
Copy link
Contributor

Description

In this PR, we attempt to fix the DB crash issue occurring for a few % of users. This happens while the SDK is being initialised. We have removed the queue-related logic to prevent any hidden thread-related issues. Additionally, since we are now calling saveEvent() from the executor in the repository class, we no longer need a separate executor for the DBInsertionHandlerThread instance creation.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • Version upgraded (project, README, gradle, podspec etc)
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit tests for the code
  • I have made corresponding changes to the documentation

As the crash is related to the queue, we attempted to remove the queue-related logic to prevent any hidden thread-related issues. Additionally, since we are now calling saveEvent from the executor in the repository class, we no longer need a separate executor for DBInsertionHandlerThread instance creation.
Copy link

sonarcloud bot commented Jun 21, 2024

@1abhishekpandey 1abhishekpandey mentioned this pull request Jun 21, 2024
10 tasks
@1abhishekpandey 1abhishekpandey merged commit 9251b68 into develop Jun 25, 2024
12 checks passed
@1abhishekpandey 1abhishekpandey deleted the fix/sdk-2027-fix-database-crash-issue branch June 25, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants