test: migrate install* and inheritable_workspace_fields to snapbox #14170
+1,217
−1,080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @weihanglo rustbot has assigned @weihanglo. Use |
rustbot
added
the
S-waiting-on-review
eth3lbert
force-pushed
the
snapbox-i
branch
3 times, most recently
from
6810f0d
to
c27d3f9
Compare
eth3lbert
commented
Jun 30, 2024
| @@ -1429,6 +1385,7 @@ fn use_path_workspace() { | |||
| assert_eq!(lock, lock2, "different lockfiles"); | |||
| } | |||
|
|
|||
| #[allow(deprecated)] | |||
There was a problem hiding this comment.
with_stderr_does_not_contain is being used in this function.
| // Particularly avoid "Installed package `ws-root v0.1.0 ([..]])` (executable `ws-member`)": | ||
| .with_stderr_does_not_contain("ws-member") | ||
| .run(); | ||
| } | ||
|
|
||
| #[allow(deprecated)] |
There was a problem hiding this comment.
with_stderr_does_not_contain is being used in this function.
| .run(); | ||
| } | ||
|
|
||
| #[allow(deprecated)] |
There was a problem hiding this comment.
with_stderr_does_not_contain is being used in this function.
Comment on lines
+2091
to
+2106
| .with_stderr_data(str![[r#" | ||
| [UPDATING] git repository `[ROOTURL]/foo` | ||
| [ERROR] invalid type: integer `3`, expected a boolean | ||
| --> home/.cargo/git/checkouts/foo-[HASH]/[..]/Cargo.toml:6:27 | ||
| | | ||
| 6 | incremental = 3 | ||
| | ^ | ||
| | | ||
| [ERROR] invalid type: integer `3`, expected a boolean | ||
| --> home/.cargo/git/checkouts/foo-[HASH]/[..]/Cargo.toml:6:27 | ||
| | | ||
| 6 | incremental = 3 | ||
| | ^ | ||
| | | ||
|
|
||
| "#]]) |
There was a problem hiding this comment.
I'm not sure if the duplicated error message shown here is correct. Therefore, I'm currently avoiding redacting with glob intentionally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Part of #14039.
Migrate following to snapbox:
tests/testsuite/inheritable_workspace_fields.rstests/testsuite/install.rstests/testsuite/install_upgrade.rs