Add procedure for new compiler team members/contributors #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hm, is this forgotten |
|
Yeah, it looks like this was an unlucky PR? Would be good to have this process documented somewhere |
davidtwco
requested changes
Sep 20, 2023
|
|
||
| ## Nominating new compiler team contributors | ||
|
|
||
| 1. A team member sends an email to `[email protected]` with the name/username of the individual being nominated and a brief explanation of why they are being nominated. |
There was a problem hiding this comment.
We've discussed since retiring the mailing lists or using them less, so maybe we can change this to posting in our private Zulip stream?
|
|
||
| ## Nominating new compiler team members | ||
|
|
||
| 1. A team member sends an email to `[email protected]` with the name/username of the individual being nominated and a brief explanation of why they are being nominated. |
|
|
||
| - Write a post for the "Inside rust" blog announcing the change! Tweet for visibility. | ||
|
|
||
| [RFC 2689]: https://rust-lang.github.io/rfcs/2689-compiler-team-contributors.html |
There was a problem hiding this comment.
I'd suggest adding a section at the bottom with our process for moving people to alumni when they're no longer active (incl. removing from the Zulip stream, etc.)
lqd
reviewed
Sep 20, 2023
|
|
||
| ## Nominating new compiler team contributors | ||
|
|
||
| 1. A team member sends an email to `[email protected]` with the name/username of the individual being nominated and a brief explanation of why they are being nominated. |
There was a problem hiding this comment.
Another comment on that same line: would "a team member" here mean that contributors (since they aren't members) cannot nominate people for contributor status? That has happened a few times already IIRC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote these since the last time I did this, I forgot about adding them to the appropriate Zulip stream.
r? @pnkfelix