Allow the user to register the application delegate on macOS and iOS #3758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
added
S - enhancement
This was referenced Jun 24, 2024
madsmtm
force-pushed
the
madsmtm/remove-app-delegates
branch
from
ae4da6c
to
33670a2
Compare
1 task
madsmtm
force-pushed
the
madsmtm/remove-app-delegates
branch
from
33670a2
to
5b45632
Compare
madsmtm
force-pushed
the
madsmtm/remove-app-delegates
branch
4 times, most recently
from
979795a
to
39b651e
Compare
This is a breaking change, although unlikely to matter in practice, since the return value of `application:didFinishLaunchingWithOptions:` is seldom used by the system.
This allows the user to override the application delegate themselves, which opens several doors for customization that were previously closed.
madsmtm
force-pushed
the
madsmtm/remove-app-delegates
branch
from
39b651e
to
4a53350
Compare
daxpedda
approved these changes
Jun 28, 2024
kchibisov
approved these changes
Jun 29, 2024
There was a problem hiding this comment.
I'm not that familiar with observers, but it looks ok-ish? I know that it works by appkit basically signalling you when something happens and you can register a lot of observers.
Also does it affect performance/input latency in any aspect or it's all the same because macOS is just giant message passing infra already and dispatching observer is not slower than dispatching regular methods?
| ); | ||
| // TODO(madsmtm): Use `MainThreadBound` once that is possible in `static`s. | ||
| thread_local! { | ||
| static GLOBAL: OnceCell<Rc<AppState>> = const { OnceCell::new() }; |
There was a problem hiding this comment.
What's the reason to Rc thread local global? I'd assume the main reason is that the user creates it in Rc and shares the pointer with winit, thus it's correctly ref-counted.
And you're using global here just for simplicity?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Register for event-loop lifecycle events using the
NSNotificationAPI instead of application delegates. This gives the user full control over the application delegate, which opens several doors for customization that were previously closed.In particular, this fixes #1751, closes #3713, fixes #2674, fixes #3499, fixes #3650 and fixes #2141, all by allowing the user to override
[NS|UI]ApplicationDelegatethemselves outside Winit.Also fixes #1281 by listening on notifications instead of using the application delegate.
Resolves part of the macOS side of #2120.
changelogmodule if knowledge of this change could be valuable to users