Fixing two runtime issues on current version from pip #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an error about
RuntimeError: Task <Task pending name='Task-8' coro=<Event.wait() running at /usr/lib64/python3.8/asyncio/locks.py:309> cb=[_release_waiter(<Future pendi...8094c9070>()]>)() at /usr/lib64/python3.8/asyncio/tasks.py:429]> got Future <Future pending> attached to a different loop
in await asyncio.wait_for(self._notifyevent.wait(), timeout)
at bleakconnection.py, line 101
The callback now receives a BleakGATTCharacteristic object such that the integer handle needs to be retrieved from an attribute.
rytilahti
reviewed
Oct 3, 2022
There was a problem hiding this comment.
Hey, thanks for the PR and sorry for the delay. Looks like there's another PR (#64) that aims to do similar (or related) changes, I mentioned there that the characteristic handling should be done in a separate PR than the rest. Wrt. Event handling, your proposal looks good to me but I have no device to test it on right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into two issues preventing me to access the device which I could fix as attached. Please take a look!
Best regards and thanks for the great work to make the thermostats accessible!