[master] Allow Homebrew package manager in all systems but Windows #66609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
cdalvaro
force-pushed
the
feature/allow_homebrew_in_all_systems
branch
2 times, most recently
from
4c49cdc
to
389dd3c
Compare
cdalvaro
changed the title
cdalvaro
changed the title
cdalvaro
force-pushed
the
feature/allow_homebrew_in_all_systems
branch
from
cda68ec
to
64e7a45
Compare
cdalvaro
changed the title
cdalvaro
commented
Jun 4, 2024
| @@ -231,6 +231,14 @@ def is_aarch64(): | |||
| return platform.machine().startswith("aarch64") | |||
|
|
|||
|
|
|||
| @real_memoize | |||
| def is_arm64(): | |||
There was a problem hiding this comment.
Not really sure about adding this new method instead of modifying the existing aarch64 with something like this:
return re.search(r'^(aarch|arm)64', platform.machine()) is not NoneI think my initial approach is more conservative, since I'm not modifying the current behavior of the is_aarch64 method. But essentially, Aarch64 and ARM64 are two different ways to refer the same thing.
TL;DR: Aarch64 is how the LLVM community refers to this architecture while Apple calls it ARM64.
There was a problem hiding this comment.
I would like to ask the opinion of @s0undt3ch and @krionbsd. Since Kirill implemented the original is_aarch64 method and Pedro is one of the main developers for macOS support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes the restriction for using mac_brew_pkg module only on macOS systems, since Homebrew can be run in Linux too: https://docs.brew.sh/Homebrew-on-Linux
I think that the module could be renamed to
brew_pkginstead ofmac_brew_pkg. But I need some help here to understand what changes are needed for this to be made.Merge requirements satisfied?
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.
See GitHub's page on GPG signing for more information about signing commits with GPG.