Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC: Type4Py server integration #2

Merged
merged 31 commits into from
Jul 7, 2021
Merged

PoC: Type4Py server integration #2

merged 31 commits into from
Jul 7, 2021

Conversation

elatoskinas
Copy link
Collaborator

@elatoskinas elatoskinas commented Jun 23, 2021

Integrates the Type4Py inference server component to the extension.

  • Logic to send API request after triggering a command for a target file. Requests are sent using the added axios dependency
  • Add type hierarchy for response data
  • Transformation of response to extension-friendly format
  • Integration of Type4Py data
  • Added sample test Python files to try extension on

Future work:

  • Update README
  • Functions within classes are not yet supported, will require transformation logic changes from API response to the extension data structure
  • Variable annotations are not supported by the forked extension. Will need to add new logic to pattern-match on variables in the file and then hook-up the inference data map to integrate the feature
    • Module-level
    • Function-level
    • Class-level
  • No return type: Add None annotation suggestion
  • Do not send a request to the server for files larger than 1K LoC.
  • Exception handling can be improved
  • Cleaning up the repo of unneeded forked functionality
  • Add setting to enable tc?
  • Handle new server return format (response and error)
  • Refactor (group/split into files) & improve docs

Copy link
Member

@mir-am mir-am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM. We'll discuss more implementation details and current issues in our meeting.

elatoskinas and others added 23 commits June 24, 2021 12:05
@mir-am mir-am added the enhancement New feature or request label Jul 7, 2021
@mir-am
Copy link
Member

mir-am commented Jul 7, 2021

Let's merge this!

@mir-am mir-am merged commit efc1269 into main Jul 7, 2021
@mir-am mir-am deleted the poc-server-integration branch July 15, 2021 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants