Use Configuration type in licenseConfigurations #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdedetrich
force-pushed
the
use-configuration-type-in-licenseConfigurations
branch
3 times, most recently
from
35b2159
to
511a00e
Compare
mdedetrich
force-pushed
the
use-configuration-type-in-licenseConfigurations
branch
from
511a00e
to
0be9f86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally this should have originally been typed to use
Configurationrather thanStringsince SBT already provides this abstraction as its own type.This is obviously a breaking change so if we care about binary/source compatibility then it would have to be for 2.0.x (in which case we can setup a branch for 2.0.x or we can just not merge PR until we expect more breaking changes for the 2.0.x series).