Add support for BSP TestParamsData kinds #2360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for TestParamsData kinds as defined in the scala extension of BSP. This allows clients to specify which test classes / tests to run
|
I could not find any tests for test bsp service, but maybe I was looking in the wrong place? |
Did you take a look at |
TestTask.discoverTestSuites where it did not filter on which test should should run when explicitly passing list of test classes (fully qualified) Included tests for running specific test suites, and tests within suites
tgodzik
approved these changes
Jul 1, 2024
|
It's good to merge as is I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for TestParamsData kinds as defined in the scala extension of BSP. This allows clients to specify which test classes / tests to run
Relevant bsp documentation: https://build-server-protocol.github.io/docs/extensions/scala#testparamsdata-kinds
Fixed a bug? in the TestTask.discoverTestSuites where it did not filter on which test should should
run when explicitly passing list of test classes (fully qualified)
Included tests for running specific test suites, and tests within suites