Add TableMetadataService and utils #1772
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
brfrn169
reviewed
May 29, 2024
| * @param columnNames List of all column names in a table | ||
| * @return The field is metadata or not | ||
| */ | ||
| public static boolean isMetadataColumn( |
There was a problem hiding this comment.
We might be able to use ConsensusCommitUtils here. Could you please check it?
Torch3333
approved these changes
Jun 4, 2024
| DATA_LOADER_INVALID_COLUMN_KEY_PARSING_FAILED( | ||
| Category.USER_ERROR, "0136", "Invalid key: Column %s does not exist in the table.", "", ""), | ||
| DATA_LOADER_INVALID_VALUE_KEY_PARSING_FAILED( | ||
| Category.USER_ERROR, "0137", "Parsing of key value %s failed. Details:%s.", "", ""), |
There was a problem hiding this comment.
Suggested change
| Category.USER_ERROR, "0137", "Parsing of key value %s failed. Details:%s.", "", ""), | |
| Category.USER_ERROR, "0137", "Parsing of key value %s failed. Details: %s.", "", ""), |
|
Converting to draft PR because, as Suzuki san mentioned, this PR might not be necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a service and utils that deal with ScalarDB TableMetada. This service and utils will be used for both export and import processes.
Related issues and/or PRs
This PR depends on the following PRs and should be reviewed and merged after:
Changes made
Checklist
Additional notes (optional)
NA
Release notes
NA