Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should return true for system namespace in namespaceExists() #2026

Merged

Conversation

brfrn169
Copy link
Collaborator

@brfrn169 brfrn169 commented Jul 3, 2024

Description

This is for the 3 branch.

Currently, when the system namespace is not created yet, the getNamespaceNames() API returns the system namespace but the namespaceExists() API with the system namespace returns false. This PR addresses this issue.

Related issues and/or PRs

Changes made

  • Added check for the system namespace to namespaceExists() for each storage adaptor.

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

N/A

Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Copy link
Contributor

@Torch3333 Torch3333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

feeblefakie

This comment was marked as duplicate.

@brfrn169 brfrn169 merged commit c5a00bd into 3 Jul 5, 2024
47 checks passed
@brfrn169 brfrn169 deleted the should-return-true-for-system-namespace-in-namespaceExists branch July 5, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants