Index all addon records, and allow public addons to the public. #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discovered two issues with addon records. First, if a single addon record was created or updated it would only be indexed if it was public. Second, public users could not see addons in the search results. This patch fixes both of those issues.
The change to
lib/SolrSearch/Addon/Manager.phpwill index all addon records regardless to if they are public or not.The changes to
lib/SolrSearch/Addon/Indexer.phpmake sure that thepublicfield is set on the addon record's document, instead of that field always being null. This allows the public to see those records. TheisRecordIndexedmethod is changed toisRecordPublicto match its new role in setting thepublicfield. The_addFlagmethod is removed as it is made redundant to checks against thepublicfield.