Skip to content

make it more obvious the bot is doing stuff #87

make it more obvious the bot is doing stuff

make it more obvious the bot is doing stuff #87

Triggered via push February 27, 2024 03:27
Status Success
Total duration 2m 32s
Artifacts

linters.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

21 warnings
Rustfmt
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rustfmt
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
unused "map closure" when calling `Result::map_or_else` value: scripty_bot_utils/src/voice_message.rs#L135
warning: unused "map closure" when calling `Result::map_or_else` value --> scripty_bot_utils/src/voice_message.rs:135:18 | 135 | let redis_res = scripty_redis::run_transaction::<Option<bool>>("GET", |cmd| { | _____________________^ 136 | | cmd.arg(format!("msg_transcript_{}", guild.get())); 137 | | }) 138 | | .await ... | 144 | | |r| r, 145 | | ); | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_result_map_or_else = note: `#[warn(clippy::unnecessary_result_map_or_else)]` on by default help: consider using `unwrap_or_else` | 135 ~ let redis_res = scripty_redis::run_transaction::<Option<bool>>("GET", |cmd| { 136 ~ cmd.arg(format!("msg_transcript_{}", guild.get())); 137 ~ }) 138 ~ .await.unwrap_or_else(|e| { 139 ~ error!("failed fetching from redis: {}", e); 140 ~ None 141 ~ }); |
this function has too many arguments (16/7): scripty_audio_handler/src/events/voice_tick.rs#L30
warning: this function has too many arguments (16/7) --> scripty_audio_handler/src/events/voice_tick.rs:30:1 | 30 | / pub async fn voice_tick( 31 | | voice_data: VoiceTick, 32 | | ssrc_state: Arc<SsrcMaps>, 33 | | guild_id: GuildId, ... | 46 | | kiai_client: KiaiApiClient, 47 | | ) { | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (9/7): scripty_audio_handler/src/events/driver_disconnect.rs#L17
warning: this function has too many arguments (9/7) --> scripty_audio_handler/src/events/driver_disconnect.rs:17:1 | 17 | / pub async fn driver_disconnect( 18 | | guild_id: GuildId, 19 | | reason: Option<DisconnectReason>, 20 | | ctx: Context, ... | 26 | | seen_users: SeenUsers, 27 | | ) { | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (9/7): scripty_audio_handler/src/audio_handler.rs#L75
warning: this function has too many arguments (9/7) --> scripty_audio_handler/src/audio_handler.rs:75:2 | 75 | / pub async fn new( 76 | | guild_id: GuildId, 77 | | webhook: Webhook, 78 | | context: Context, ... | 84 | | kiai_client: KiaiApiClient, 85 | | ) -> Result<Self, sqlx::Error> { | |__________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default
function `handle_error` is never used: scripty_audio_handler/src/events/voice_tick.rs#L493
warning: function `handle_error` is never used --> scripty_audio_handler/src/events/voice_tick.rs:493:4 | 493 | fn handle_error<'a>(error: ModelError, ssrc: u32) -> ExecuteWebhook<'a> { | ^^^^^^^^^^^^
field `auto_detect_lang` is never read: scripty_audio_handler/src/events/voice_tick.rs#L108
warning: field `auto_detect_lang` is never read --> scripty_audio_handler/src/events/voice_tick.rs:108:2 | 97 | struct SilentSpeakersContext { | --------------------- field in this struct ... 108 | auto_detect_lang: Arc<AtomicBool>, | ^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
the item `sqlx` is imported redundantly: scripty_audio_handler/src/error.rs#L7
warning: the item `sqlx` is imported redundantly --> scripty_audio_handler/src/error.rs:7:5 | 7 | use scripty_db::sqlx; | ^^^^^^^^^^^^^^^^ the item `sqlx` is already defined here | = note: `#[warn(unused_imports)]` on by default
the item `tokio` is imported redundantly: scripty_stt/src/ffprobe.rs#L4
warning: the item `tokio` is imported redundantly --> scripty_stt/src/ffprobe.rs:4:13 | 4 | use tokio::{self, io, io::AsyncReadExt}; | ^^^^ the item `tokio` is already defined here | = note: `#[warn(unused_imports)]` on by default
this function has too many arguments (8/7): scripty_automod/src/types.rs#L73
warning: this function has too many arguments (8/7) --> scripty_automod/src/types.rs:73:2 | 73 | / pub fn new( 74 | | guild_id: u64, 75 | | internal_id: i32, 76 | | enabled: bool, ... | 81 | | auto_join_voice: bool, 82 | | ) -> Self { | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default
Clippy
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/