Add support for Pine64 Star64 #174
Conversation
|
What does is mean "most stable"? Can you make this a bit more specific, is it the OpenSBI build/boot flow that works better? Or the U-Boot boot flow? Or the platform specific tooling? |
Ivan-Velickovic
force-pushed
the
star64
branch
from
c1e35e9
to
a604f39
Compare
I meant just in general, with a binary image you just set the program counter and jump to it whereas with an ELF or other file formats their is more space to get things wrong. One example I've had in the past when using In addition, a binary works with the regular boot flow of the Star64 but also with FW_PAYLOAD and FW_JUMP with OpenSBI. |
| @@ -56,6 +59,9 @@ function(ApplyData61ElfLoaderSettings kernel_platform kernel_sel4_arch) | |||
| endif() | |||
| set(IMAGE_START_ADDR 0x10000000 CACHE INTERNAL "" FORCE) | |||
| endif() | |||
| if(KernelPlatformStar64) | |||
| set(IMAGE_START_ADDR 0x60000000 CACHE INTERNAL "" FORCE) | |||
There was a problem hiding this comment.
Can you add a comment where this address comes from?
There was a problem hiding this comment.
I'm not sure what I would say because it comes from the same place as all the other addresses in that file - somewhere in RAM that doesn't overlap with anything.
There was a problem hiding this comment.
Ah ok, could say this for the whole section then, that it's an arbitrary choice unless stated otherwise. That answer feels lika a deja-vu somehow.
Signed-off-by: Ivan-Velickovic <[email protected]>
The motivation for using a binary image is that it is (in my experience) the most stable.