Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fix for the autocompletion in the field "Filter by tag" #104

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Small fix for the autocompletion in the field "Filter by tag" #104

wants to merge 3 commits into from

Conversation

romnGit
Copy link

@romnGit romnGit commented Jul 8, 2013

Edit: sorry, i don't want to pull the commit "pre-filled description [...]" (https://github.com/romnGit/Shaarli/commit/66a386d5bd9655b0b92adeea8f0233650106b2c9) but only the fix for the autocompletion.

@arnaudmm
Copy link

arnaudmm commented Sep 2, 2013

+1
I was going to report the same issue
Very simple to fix, the id in jquery selector is not the good one.

@nodiscc
Copy link

nodiscc commented Aug 10, 2014

@romnGit Since this pull request does not merge properly, I have proposed a pull request regarding the pre-filled "description" field at shaarli#19 using your changes. Thanks!

I still don't get what the autocompletion part is supposed to do.

@nodiscc
Copy link

nodiscc commented Nov 6, 2014

@romnGit Ok I finally understand the change of selector :) Had not seen your reply and this was what confusing me:
Problem: the code you have edited was removed by sebsauvage on 25 Sep 2013: shaarli@246e9b4#diff-db1d5c48a87caa31e9c9ceb298408a24L16

Removed jQuery from almost all pages
jQuery has been removed from all pages, except those who really require
it (like autocomplete in link edition).
Immediate gain: All pages weight 286 kb LESS ! \o/
Highlighting in search results has also been temporarly removed (and
will be re-implemented).

So this is not possible to merge :/

If you want, you can have a try with recent code at https://github.com/shaarli/Shaarli/
I get no autocomplete in the Filter Tag box and it would be nice. Don't know if this is possible without re-adding jQuery...

@nodiscc
Copy link

nodiscc commented Nov 8, 2014

@romnGit ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants