Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unzip datafiles feature #1925

Merged
merged 22 commits into from
Jul 11, 2024
Merged

Conversation

AndrewWood94
Copy link
Contributor

Adds ability to unzip datafiles and save contents as new datafiles, which can be linked to any assay the zipped folder is linked to.

Notes:

  • A way to link multiple datafiles to an assay simultaneously would be useful if users forget to link in the unzip process
  • Nothing is implemented to handle new datafile versions not matching the original zip contents, this could be added in a similar manner to updating extracted samples
  • Unzipped datafiles do not have a creator, similar to extracted samples
  • Currently no tests have been written for this feature

@stuzart stuzart added this to the 1.16.0 milestone Jul 11, 2024
Copy link
Member

@stuzart stuzart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code is good, and gave it a run through and test and it works quite nicely. thanks.

I will merge this and add some tests on a separate branch (since I can't push to this one).

If you agree, I also thought I could make the creators default to the same as the original zip file. I was also thinking of showing the origin zip file as part of the metadata on the data file show page.

@stuzart stuzart merged commit d8625e4 into seek4science:main Jul 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants