CLOSED: issues 8 and 9 enhancements to calendar attributes (to dateoffsets) and simplified status delivery #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… functionality on front-end, implemented multiindex pipeline, opted to remove custom front-end objects all together (i.e. FedDepartment). This knocked a few modules (_tree, _dept_status, and _depts) out in one fell swoop leaving something infinitely easier to maintain. I will also likely consolidate what's left in constants elsewhere, or rename it.
…on ingestion and some consolidation. constants.py and _interval_store.py are gone. Began refactor of FedHolidays as AbstractHolidayCalendar. _meta renamed to _base
… as pandas DateOffset subclasses, the same for MilitaryPayDay. Work ongoing for the same treatment of ProbableMilitaryPassday
…dstamp and fedindex then merge
…functionality is there just not fully integrated...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completely revamped back-end across the library, simplifying status handling using json import and pandas native objects. Rebuilt supporting calendar classes as pandas DateOffset children; adding numpy vectorized and array-based operations (even when not available in pandas itself). FedPayDay, FedBusinessDay, FedHolidays, MilitaryPayDay, and MilitaryPassDay are all pandas offset objects now.
Still need to integrate changes into FedStamp and FedIndex, but given the huge restructuring (and current lack of usership), it's time to merge with dev and get the show on the road.
CLOSES Refactor Date Attributes to Make More Effective Use of Pandas offset classes #9
CLOSES Restructure and Simplify Department Status Management and Delivery #8