Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown fix #604

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Conversation

cn1t
Copy link
Member

@cn1t cn1t commented Aug 24, 2023

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Project infrastructure change (like issue templates, etc.)

How Has This Been Tested?

Please check all browsers you have tested on. Please also list any relevant details for your test configuration

  • Chromium Based Browser
  • Mozilla Firefox

Test Configuration:

  • Windows
  • Linux
  • MacOS
  • BSD

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I am a web developer

@cn1t cn1t requested a review from 9glenda August 24, 2023 10:13
@cn1t cn1t self-assigned this Aug 24, 2023
@cn1t cn1t linked an issue Aug 24, 2023 that may be closed by this pull request
@cn1t
Copy link
Member Author

cn1t commented Aug 24, 2023

This now uses templating and works

@cn1t
Copy link
Member Author

cn1t commented Aug 24, 2023

Finally

@cn1t cn1t linked an issue Aug 24, 2023 that may be closed by this pull request
@9glenda
Copy link
Member

9glenda commented Aug 24, 2023

Shouldn't we wait for #573 to be merged that would Marke Mord sense

@9glenda
Copy link
Member

9glenda commented Aug 24, 2023

I implemented the new dropdown thing yesterday

@9glenda
Copy link
Member

9glenda commented Aug 24, 2023

Merging this will just cause merge conflicts it will be removed as soon as I ported edit to the new dropdown implementation

@cn1t
Copy link
Member Author

cn1t commented Aug 24, 2023

But this impl is working fully and the other impl still looks weird and is less responsive and uses the same amount of code

@9glenda
Copy link
Member

9glenda commented Aug 24, 2023

The other impl is straight up bad code nobody understands it. It's just the CSS which needs to be improved in the other one. Here everything is fucking bad except for the css

@cn1t
Copy link
Member Author

cn1t commented Aug 24, 2023

The other impl is straight up bad code nobody understands it. It's just the CSS which needs to be improved in the other one. Here everything is fucking bad except for the css

nuh uh

Copy link
Member

@9glenda 9glenda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm against merging it but yeah

@cn1t cn1t merged commit a54b77d into main Aug 25, 2023
7 checks passed
@cn1t cn1t deleted the 603-website-alternate-solution-to-dropdown-problem branch August 25, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Website] Alternate solution to dropdown problem [WEBSITE BUG] Fix dropdown in guide window
2 participants