-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropdown fix #604
Dropdown fix #604
Conversation
This now uses templating and works |
Finally |
Shouldn't we wait for #573 to be merged that would Marke Mord sense |
I implemented the new dropdown thing yesterday |
Merging this will just cause merge conflicts it will be removed as soon as I ported edit to the new dropdown implementation |
But this impl is working fully and the other impl still looks weird and is less responsive and uses the same amount of code |
The other impl is straight up bad code nobody understands it. It's just the CSS which needs to be improved in the other one. Here everything is fucking bad except for the css |
nuh uh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm against merging it but yeah
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
How Has This Been Tested?
Please check all browsers you have tested on. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: